Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Socket.io to 1.7.4 to avoid issue with ws@1.1.2 #2744

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

wehriam
Copy link
Contributor

@wehriam wehriam commented Jun 13, 2017

See #2593

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@wehriam
Copy link
Contributor Author

wehriam commented Jun 13, 2017

I signed it!

@wehriam
Copy link
Contributor Author

wehriam commented Jun 14, 2017

Trying the Google CLA process again...

@googlebot
Copy link

CLAs look good, thanks!

@wehriam
Copy link
Contributor Author

wehriam commented Jun 14, 2017

@creat-or any additional changes required for this to be merged and released?

@27leaves
Copy link

27leaves commented Jun 18, 2017

Yeah, it has no sense that I approved it, since I have no write privileges on this repository. I just can't wait that this will be merged ;)

@27leaves
Copy link

Could somebody please review and merge that fix? It's really small and has a lot of impact ;)

@dignifiedquire
Copy link
Member

The issue why this was not updated before is that there were breaking changes in socket.io before regarding ie7. Does someone have insight into the state of this?

@27leaves
Copy link

Do you mean this one? socketio/socket.io-client#1099 ... doesn't seem like much activity on this side.

@wehriam
Copy link
Contributor Author

wehriam commented Jun 26, 2017

@creat-or I was experiencing #2593 which has been resolved by bumping Socket.io to 1.7.4.

@dignifiedquire
Copy link
Member

Alright I'll take a look at merging things later tonight

@dignifiedquire dignifiedquire merged commit 264442b into karma-runner:master Jun 26, 2017
@sujaykathrotia
Copy link

Can we have minor version release with this fixed? I believe a lot of people are having this issue and it would be great to have this fixed in npm instead of patching it manually.

@dalper01
Copy link

I'd also like a minor release with this. I can patch my dev environment, but my Travis karma tests have been failing and probably will continue to until I can ref a release with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants